[webkit-reviews] review granted: [Bug 63979] garden-o-matic shouldn't show flaky tests by default : [Attachment 99798] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 63979: garden-o-matic shouldn't show flaky tests by default
https://bugs.webkit.org/show_bug.cgi?id=63979

Attachment 99798: Patch
https://bugs.webkit.org/attachment.cgi?id=99798&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99798&action=review

> Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:9
> +var kPassingResults = ['PASS'];

Using an array here seems like overkill to me. I think a string would do.

> Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:10
> +var kPassingResults = ['PASS'];
>  var kFailingResults = ['TIMEOUT', 'TEXT', 'CRASH', 'IMAGE','IMAGE+TEXT'];

Should have mentioned in a previous review, you might want to alias these
strings, e.g.
var TIMEOUT = 'TIMEOUT';

It will save you pain down the road for when you typo 'TIMEOT'. With the
variables, you'll get a nice JS exception right where the problem code is.