[webkit-reviews] review granted: [Bug 63964] Force inlining of simple functions that show up as not being inlined : [Attachment 99769] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 63964: Force inlining of simple functions that show up as not being inlined
https://bugs.webkit.org/show_bug.cgi?id=63964

Attachment 99769: Patch
https://bugs.webkit.org/attachment.cgi?id=99769&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=99769&action=review

> Source/JavaScriptCore/assembler/LinkBuffer.h:251
> +	       uint16_t* copySource = reinterpret_cast<uint16_t*>(inData +
readPtr);

I kinda think it would be nice to add a couple more asserts, check ing that the
points are aligned, and that the regions do not overlap.  But I leave that to
your personal taste. r+ either way.