[webkit-reviews] review granted: [Bug 63839] buildbot needs to understand whether NRWT exited early after having too many failures : [Attachment 99750] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 63839: buildbot needs to understand whether NRWT exited early after having
too many failures
https://bugs.webkit.org/show_bug.cgi?id=63839

Attachment 99750: Patch
https://bugs.webkit.org/attachment.cgi?id=99750&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99750&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:212
> +    results['interrupted'] = interrupted  # Does results.html have enough
information to compute this itself? (by checking total number of results vs.
total number of tests?)

I doubt it.  You can restrict the test set in a bunch of different ways.