[webkit-reviews] review granted: [Bug 21591] prepare-ChangeLog should know how to find functions in Perl files : [Attachment 99751] Make prepare-ChangeLog include modified Perl functions in its ChangeLog template

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 5 15:13:16 PDT 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 21591: prepare-ChangeLog should know how to find functions in Perl files
https://bugs.webkit.org/show_bug.cgi?id=21591

Attachment 99751: Make prepare-ChangeLog include modified Perl functions in its
ChangeLog template
https://bugs.webkit.org/attachment.cgi?id=99751&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99751&action=review

r=me!

> Tools/Scripts/prepare-ChangeLog:1232
> +		   warn "nested functions found at top-level at
$fileName:$.\n";

FYI, it is possible to nest subroutines in Perl.  You can define a subroutine
and assign it to a variable, too.

I guess you can change $currentFunction to @currentFunction later.


More information about the webkit-reviews mailing list