[webkit-reviews] review granted: [Bug 63954] run-api-tests output is very confusing on Windows : [Attachment 99747] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 63954: run-api-tests output is very confusing on Windows
https://bugs.webkit.org/show_bug.cgi?id=63954

Attachment 99747: Patch
https://bugs.webkit.org/attachment.cgi?id=99747&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99747&action=review

> Tools/Scripts/run-api-tests:308
> +    my $suffix;
> +    if (configurationForVisualStudio() ne "Debug_All") {
> +	   $suffix = "";
> +    } else {
> +	   $suffix = "_debug";
> +    }

Nit: It's usually easier to think about equal than not-equal, so I would have
written this as:

my $suffix;
if (configurationForVisualStudio() eq "Debug_All") {
   $suffix = "_debug";
} else {
   $suffix = "";
}

Alternatively, you could have written this as:
my $suffix = "";
$suffix = "_debug" if configurationForVisualStudio() eq "Debug_All";

> Tools/Scripts/run-api-tests:309
> +    return $path . $suffix . ".exe";

You can use string interpolation and write this as  "$path$suffix.exe".