[webkit-reviews] review granted: [Bug 63573] REGRESSION (r88415): Range slider doesn't have focus appearance. : [Attachment 99217] Patch 2

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 63573: REGRESSION (r88415): Range slider doesn't have focus appearance.
https://bugs.webkit.org/show_bug.cgi?id=63573

Attachment 99217: Patch 2
https://bugs.webkit.org/attachment.cgi?id=99217&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99217&action=review

> LayoutTests/fast/forms/input-appearance-range.html:7
>     - three horizontal sliders with various thumb positions.
> +	- The second slider has focus.
>     - a vertical slider

Indentation looks strange here.

> Source/WebCore/rendering/RenderThemeMac.mm:1321
> +    updateFocusedState(sliderThumbCell, o->node() &&
o->node()->focusDelegate()->renderer() ? o->node()->focusDelegate()->renderer()
: o);

Can you put parentheses around the ternary operator condition for clarity? Some
compilers might actually produce a warning otherwise.