[webkit-reviews] review granted: [Bug 62997] [Qt] Add shadowblur support : [Attachment 98949] Patch.

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Igor Trindade Oliveira
<itrindade.oliveira at gmail.com>'s request for review:
Bug 62997: [Qt] Add shadowblur support
https://bugs.webkit.org/show_bug.cgi?id=62997

Attachment 98949: Patch.
https://bugs.webkit.org/attachment.cgi?id=98949&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98949&action=review

r=me, but please fix GraphicsContext::clipBounds() before landing.

Also, are there really no changes to the pixel results of canvas and CSS shadow
tests?

> Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp:818
> +    return IntRect(clipRect.x(), clipRect.y(), clipRect.width(),
clipRect.height());

This should be return enclosingIntRect(clipRect); or we may get 1px rounding
errors.