[webkit-reviews] review granted: [Bug 63235] [Qt] Fix tst_QWebFrame::setHtmlWithResource() API test : [Attachment 99726] modified style as suggested, and also have split the test into two (one for image, and other for stylesheet)

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Rafael Brandao
<rafael.lobo at openbossa.org>'s request for review:
Bug 63235: [Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
https://bugs.webkit.org/show_bug.cgi?id=63235

Attachment 99726: modified style as suggested, and also have split the test
into two (one for image, and other for stylesheet)
https://bugs.webkit.org/attachment.cgi?id=99726&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99726&action=review

Looks good.

> Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:2531
> +    QLatin1String html = QLatin1String(htmlData);

QLatin1String html(htmlData);

> Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:2536
> +    frame->setHtml(html, QUrl(QLatin1String("qrc:file")));

qrc:file is not a valid qrc url (maybe it is at the moment but that is not very
robust). Better use qrc:///file (I can't remember if that should be 2 or 3 /
:))

> Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:2546
> +    QCOMPARE(webElement.styleProperty("color", QWebElement::CascadedStyle),
QLatin1String(""));

QLatin1String("") -> QString() I guess