[webkit-reviews] review granted: [Bug 63909] Remove virtual functions from StyleImage. : [Attachment 99675] Remove virtual functions from StyleImage

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Czene Tamas
<Czene.Tamas at stud.u-szeged.hu>'s request for review:
Bug 63909: Remove virtual functions from StyleImage.
https://bugs.webkit.org/show_bug.cgi?id=63909

Attachment 99675: Remove virtual functions from StyleImage
https://bugs.webkit.org/attachment.cgi?id=99675&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=99675&action=review

> Source/WebCore/ChangeLog:10
> +	   Some profile data shows this part is significant, especially in
small CSS-based sites.
> +	   Removing the virtual functions - removing the calls - makes a small
performance progression on this part.

You should put more information in the bug about your performance
investigations. What sites did you test? What as the measured gain? What stack
traces show time in these methods?