[webkit-reviews] review requested: [Bug 56200] [GTK] WebKitIconDatabase doesn't keep icons cached : [Attachment 99704] Another patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 56200: [GTK] WebKitIconDatabase doesn't keep icons cached
https://bugs.webkit.org/show_bug.cgi?id=56200

Attachment 99704: Another patch
https://bugs.webkit.org/attachment.cgi?id=99704&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
I've noticed that there's FrameLoaderClient::registerForIconNotification()
which is called when the icon is in the database, but its data is not yet
available. In that case we can register a notification request in the database,
and when notified call FrameLoaderClient::dispatchDidReceiveIcon(). This way we
can make sure that webkit_icon_database_get_icon_pixbuf() will always return a
valid pixbuf when called in the icon-loaded callback. The patch also adds
support for favicons to GtkLauncher, although we should probably add a unit
test for this too.