[webkit-reviews] review denied: [Bug 55489] Web Inspector: Searching on the Network panel doesn't do anything? : [Attachment 99642] [patch] initial version. with styles fixes.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 55489: Web Inspector: Searching on the Network panel doesn't do anything?
https://bugs.webkit.org/show_bug.cgi?id=55489

Attachment 99642: [patch] initial version. with styles fixes.
https://bugs.webkit.org/attachment.cgi?id=99642&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99642&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:1097
> +	   if (!(resource._displayName &&
resource._displayName.match(this._searchRegExp)) &&

Checking path is sufficient.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1101
> +	   if (resource.identifier in this._matchedResourcesIdMap) {

no need for {}

> Source/WebCore/inspector/front-end/NetworkPanel.js:1107
> +	   node._addStyleClass("search-matched-item");

See highlightSearchResult in utilities.js and its usages on how to highlight
search match.