[webkit-reviews] review denied: [Bug 15799] textPath element does not re-render when referenced path changes : [Attachment 99657] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 15799: textPath element does not re-render when referenced path changes
https://bugs.webkit.org/show_bug.cgi?id=15799

Attachment 99657: Patch
https://bugs.webkit.org/attachment.cgi?id=99657&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99657&action=review

Not meant as a real review but r- because of the following:

> LayoutTests/ChangeLog:6
> +	   Bug 15799: textPath element does not re-render when referenced path
changes
> +	   https://bugs.webkit.org/show_bug.cgi?id=15799

Is it not possible to move some of the tests to dumpText tests (if not all)?
Looks like all tests just draw text.

> Source/WebCore/ChangeLog:9
> +	   Support textPath updating to changes on the referenced path. To make
this possible
> +	   refactor the event listener logic from SVGTRefElement into
SubtreeModificationEventListener.

You added new files, moved code, changed functionality of certain things... You
should describe all that in detail. You don't have to do that in the
description body. You can comment the changes line by line below. Missing
descriptions make it harder to get the context and review your patch.