[webkit-reviews] review denied: [Bug 63920] Guarding header file inclusion in proper compilation flags. : [Attachment 99662] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 5 00:10:23 PDT 2011
Alexey Proskuryakov <ap at webkit.org> has denied nayankk at motorola.com
<nayankk at motorola.com>'s request for review:
Bug 63920: Guarding header file inclusion in proper compilation flags.
https://bugs.webkit.org/show_bug.cgi?id=63920
Attachment 99662: Patch
https://bugs.webkit.org/attachment.cgi?id=99662&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
These files should always be generated, and they should have #if checks inside.
Uglifying every .cpp file with tons of #if checks makes no sense.
More information about the webkit-reviews
mailing list