[webkit-reviews] review denied: [Bug 62447] dump-as-markup.js should support shadow tree : [Attachment 99669] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 4 23:46:36 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has denied MORITA Hajime <morrita at google.com>'s
request for review:
Bug 62447: dump-as-markup.js should support shadow tree
https://bugs.webkit.org/show_bug.cgi?id=62447

Attachment 99669: Patch
https://bugs.webkit.org/attachment.cgi?id=99669&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99669&action=review

> LayoutTests/ChangeLog:6
> +	   Added Markup.showShadows() to enable shadow-related dump.

Long description goes after "Reviewed by"

> LayoutTests/resources/dump-as-markup.js:214
> +	       var pseudoId = internals.shadowPseudoId(node);
> +	       if (pseudoId)

You should check the existence of internals so that opening the test manually
doesn't throw errors.


More information about the webkit-reviews mailing list