[webkit-reviews] review granted: [Bug 63916] Coalesce data array into one NSData before calling didReceiveData : [Attachment 99651] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Pratik Solanki <psolanki at apple.com>'s request for
review:
Bug 63916: Coalesce data array into one NSData before calling didReceiveData
https://bugs.webkit.org/show_bug.cgi?id=63916

Attachment 99651: Patch
https://bugs.webkit.org/attachment.cgi?id=99651&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=99651&action=review

> Source/WebCore/ChangeLog:10
> +	   the data buffers into one anc all it with all the data at once.

Typo: anc.

> Source/WebCore/platform/network/mac/ResourceHandleMac.mm:-815
> -	   // The call to didReceiveData below could cancel a load, which would
result in the delegate
> -	   // (self) being released.

Perhaps this is worth replacing with a comment where there is a currently
useless return statement saying that at that point self may have been
deallocated.