[webkit-reviews] review granted: [Bug 63873] ResourceLoadNotifier::dispatchWillSendRequest should not compare StringImpl directly : [Attachment 99637] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 4 12:47:29 PDT 2011


Alexey Proskuryakov <ap at webkit.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 63873: ResourceLoadNotifier::dispatchWillSendRequest should not compare
StringImpl directly
https://bugs.webkit.org/show_bug.cgi?id=63873

Attachment 99637: Patch
https://bugs.webkit.org/attachment.cgi?id=99637&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99637&action=review

> Source/WebCore/ChangeLog:9
> +	   * loader/ResourceLoadNotifier.cpp:
> +	   (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):

Even for a very simple change like this, having per-function comments in
ChangeLog would be helpful.


More information about the webkit-reviews mailing list