[webkit-reviews] review requested: [Bug 63883] Make SCM unit tests faster : [Attachment 99589] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 63883: Make SCM unit tests faster
https://bugs.webkit.org/show_bug.cgi?id=63883

Attachment 99589: Patch
https://bugs.webkit.org/attachment.cgi?id=99589&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Profiling with this patch:

   581795 function calls (573917 primitive calls) in 205.441 CPU seconds

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
       59    0.010    0.000  113.431	1.923
/Users/dbates/Desktop/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_uni
ttest.py:967(setUp)
       60    0.005    0.000   76.073	1.268
/Users/dbates/Desktop/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_uni
ttest.py:80(run_silent)
       59    0.008    0.000   75.076	1.272
/Users/dbates/Desktop/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_uni
ttest.py:956(_setup_git_checkout)
       94    0.011    0.000   62.900	0.669
/Users/dbates/Desktop/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_uni
ttest.py:172(setup)
       35    0.003    0.000   28.019	0.801
/Users/dbates/Desktop/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_uni
ttest.py:619(setUp)
      265    0.016    0.000   17.359	0.066
/Users/dbates/Desktop/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/detecti
on.py:72(detect_scm_system)
       94    0.006    0.000   11.032	0.117
/Users/dbates/Desktop/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_uni
ttest.py:211(tear_down)
	1    0.000    0.000    8.149	8.149
/Users/dbates/Desktop/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_uni
ttest.py:185(_setup_mock_repo)
       59    0.006    0.000    7.821	0.133
/Users/dbates/Desktop/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_uni
ttest.py:976(tearDown)

I moved the actual creation of the mock SVN repo from SVNTestRepository.setup()
into SVNTestRepository._setup_mock_repo(). The first call to
SVNTestRepository.setup() calls SVNTestRepository._setup_mock_repo() once then
subsequent calls creates a filesystem copy of the mock SVN repo M and performs
an SVN checkout of M.