[webkit-reviews] review granted: [Bug 63867] Move the plug-in controller member variable up to the shared Plugin base class : [Attachment 99563] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 2 16:36:41 PDT 2011


Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 63867: Move the plug-in controller member variable up to the shared Plugin
base class
https://bugs.webkit.org/show_bug.cgi?id=63867

Attachment 99563: Patch
https://bugs.webkit.org/attachment.cgi?id=99563&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99563&action=review

> Source/WebKit2/WebProcess/Plugins/Plugin.h:81
> +    virtual bool initialize(const Parameters&) = 0;

Can this be private? It seems likes only the two parameter version should ever
be called directly.


More information about the webkit-reviews mailing list