[webkit-reviews] review granted: [Bug 62599] Errors encountered within SVG documents should be reported to the console : [Attachment 97625] 0001 - Add SVGElement::reportAttributeParsingError

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 62599: Errors encountered within SVG documents should be reported to the
console
https://bugs.webkit.org/show_bug.cgi?id=62599

Attachment 97625: 0001 - Add SVGElement::reportAttributeParsingError
https://bugs.webkit.org/attachment.cgi?id=97625&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=97625&action=review

> Source/WebCore/svg/SVGElement.cpp:112
> +    String errorString = "<" + tagName() + "> attribute " +
attribute->name().toString() + "=\"" + attribute->value() + "\"";
> +    SVGDocumentExtensions* extensions = document()->accessSVGExtensions();

Is there a way to save the string-construction work if there is no console?

> Source/WebCore/svg/SVGElement.cpp:122
> +    if (error == NegativeValueForbiddenError) {
> +	   extensions->reportError("Invalid negative value for " +
errorString);
> +	   return;
> +    }
> +
> +    if (error == ParsingAttributeFailedError) {
> +	   extensions->reportError("Invalid value for " + errorString);
> +	   return;
> +    }

Could this be a switch?