[webkit-reviews] review granted: [Bug 63854] Refactor NRWT parsing logic in master.cfg to understand that run-webkit-tests might run NRWT : [Attachment 99537] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 63854: Refactor NRWT parsing logic in master.cfg to understand that
run-webkit-tests might run NRWT
https://bugs.webkit.org/show_bug.cgi?id=63854

Attachment 99537: Patch
https://bugs.webkit.org/attachment.cgi?id=99537&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99537&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:263
> +	   if logText.find("Collecting tests ...") >= 0:

Might be nice if NRWT had a slightly more obvious and reliable banner string to
grep for ... maybe we should add a "Running new-run-webkit-tests" when we're
printing the configuration or something. Not terribly important, though.