[webkit-reviews] review granted: [Bug 63848] Consider backing scale when setting up graphics layers : [Attachment 99524] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 63848: Consider backing scale when setting up graphics layers
https://bugs.webkit.org/show_bug.cgi?id=63848

Attachment 99524: Patch
https://bugs.webkit.org/attachment.cgi?id=99524&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=99524&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:111
> +    ASSERT(renderer());
> +    ASSERT(renderer()->document());
> +    ASSERT(renderer()->document()->frame());

Should these be moved to pageContentsScale()?

> Source/WebCore/rendering/RenderLayerBacking.h:195
> +    float pageContentsScale() const;

Why not just call this pageScaleFactor() to avoid introducing another term?