[webkit-reviews] review granted: [Bug 63842] Python tests are failing on leopard : [Attachment 99521] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 63842: Python tests are failing on leopard
https://bugs.webkit.org/show_bug.cgi?id=63842

Attachment 99521: Patch
https://bugs.webkit.org/attachment.cgi?id=99521&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99521&action=review

Thank you for fixing.

> Tools/Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:69
> +    def flush(self):

We might want to comment that this is only needed for Python 2.5 here.

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:54
> +SHOULD_TEST_PROCESSES = multiprocessing and sys.platform not in ('cygwin')

I would have made this a member on MainTest.  Then accessed it with
self.should_test_processes (or even an function).