[webkit-reviews] review requested: [Bug 63837] We shouldn't wait for ReportCrash while the timeout is running : [Attachment 99513] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 1 13:20:39 PDT 2011


Dirk Pranke <dpranke at chromium.org> has asked  for review:
Bug 63837: We shouldn't wait for ReportCrash while the timeout is running
https://bugs.webkit.org/show_bug.cgi?id=63837

Attachment 99513: Patch
https://bugs.webkit.org/attachment.cgi?id=99513&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99513&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py:133
> +	   self._port.executive().wait_newest(self._port.is_crash_reporter)

Does it make sense to only do this if the previous test crashed? 

Or was it your intent to block *every* worker if a crash reporter is running?
It will be interesting to see what kind of impact that has on test run time on
the many-core machines like the big mac pros and xserves.


More information about the webkit-reviews mailing list