[webkit-reviews] review denied: [Bug 63818] Test bots shouldn't attempt to build TestWebKitAPI on Windows : [Attachment 99496] CR feedback

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has denied Dmitry Lomov
<dslomov at google.com>'s request for review:
Bug 63818: Test bots shouldn't attempt to build TestWebKitAPI on Windows
https://bugs.webkit.org/show_bug.cgi?id=63818

Attachment 99496: CR feedback
https://bugs.webkit.org/attachment.cgi?id=99496&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=99496&action=review

> Tools/Scripts/run-api-tests:62
> +  --no-build 	  Do not build unit tests prior to running

The description here doesn't line up with the others.

> Tools/Scripts/run-api-tests:69
> +    'no-build' => \$noBuild

even better would be to specify this as:

my $build = 1;

--[no-]build	Build unit tests prior to running (default: $build)

'build!' => \$build

That will cause --build and --no-build to work as expected.