[webkit-reviews] review canceled: [Bug 63329] [Symbian] Fix compile error in RVCT 2.2 build : [Attachment 99346] Added comment in the code based on David's suggestion.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 1 11:21:20 PDT 2011


Daniel Bates <dbates at webkit.org> has canceled Stanislav Paltis
<Stanislav.Paltis at nokia.com>'s request for review:
Bug 63329: [Symbian] Fix compile error in RVCT 2.2 build
https://bugs.webkit.org/show_bug.cgi?id=63329

Attachment 99346: Added comment in the code based on David's suggestion.
https://bugs.webkit.org/attachment.cgi?id=99346&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99346&action=review

> Source/WebCore/rendering/RenderBlock.h:161
>      using RenderBoxModelObject::continuation;

Wouldn't we need something similar here since
RenderBoxModelObject::continuation() is also a protected method and we want to
expose its functionality in a public method?

> Source/WebCore/rendering/RenderBlock.h:162
> +    // Can’t use "using" here due to a bug in the RVCT compiler.

The encoding for the apostrophe character is messed up.


More information about the webkit-reviews mailing list