[webkit-reviews] review denied: [Bug 63818] Test bots shouldn't attempt to build TestWebKitAPI on Windows : [Attachment 99488] Fix: adds --skipbuild parameter to run-api-tests and sets that parameter on win bot

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 1 11:15:18 PDT 2011


Adam Roben (:aroben) <aroben at apple.com> has denied Dmitry Lomov
<dslomov at google.com>'s request for review:
Bug 63818: Test bots shouldn't attempt to build TestWebKitAPI on Windows
https://bugs.webkit.org/show_bug.cgi?id=63818

Attachment 99488: Fix: adds --skipbuild parameter to run-api-tests and sets
that parameter on win bot 
https://bugs.webkit.org/attachment.cgi?id=99488&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=99488&action=review

> Tools/Scripts/run-api-tests:54
> +my $skipbuild = 0;

I'd call this $skipBuild.

> Tools/Scripts/run-api-tests:62
> +  --skipbuild	   Do not build unit tests prior to running

I think our normal spelling for this is --skip-build. Though I tend to prefer
the --[no-]build style that old-run-webkit-tests uses.


More information about the webkit-reviews mailing list