[webkit-reviews] review granted: [Bug 63239] [X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of broken event propagation : [Attachment 98329] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 1 08:41:42 PDT 2011


Andreas Kling <kling at webkit.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 63239: [X11][WK2] plugins/mouse-evets-fixedpos.html is failing because of
broken event propagation
https://bugs.webkit.org/show_bug.cgi?id=63239

Attachment 98329: Patch
https://bugs.webkit.org/attachment.cgi?id=98329&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98329&action=review

I find it suspicious that the return value convention is in violation of
https://developer.mozilla.org/en/NPP_HandleEvent but it's indeed what we
already do in WebKit1.

> Source/WebKit2/ChangeLog:9
> +	   Revert the return value of NPP_HandleEvent because the plugin
function

Revert -> Invert


More information about the webkit-reviews mailing list