[webkit-reviews] review denied: [Bug 63315] [EFL] Add notifier API of network state to ewk : [Attachment 98846] Modified Patch

[bugzilla-daemon at webkit.org]

Lucas De Marchi <demarchi at webkit.org> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 63315: [EFL] Add notifier API of network state to ewk
https://bugs.webkit.org/show_bug.cgi?id=63315

Attachment 98846: Modified Patch
https://bugs.webkit.org/attachment.cgi?id=98846&action=review

------- Additional Comments from Lucas De Marchi <demarchi at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98846&action=review

> Source/WebKit/efl/ChangeLog:8
> +	   Add ewk_network_state_notifier files to ewk in order to add network
state notifier to ewk.

Do you really need another file/header? If so, what do you think of renaming it
to ewk_network.h? And in this phrase it seems like you are saying that WebCore
will send a notification to ewk. This is not really true. Look at r79563.
You're allowing access to NetworkStateNotifier rather than notifying ewk of any
change.

> Source/WebKit/efl/ChangeLog:11
> +	   * ewk/EWebKit.h:
> +	   * ewk/ewk_network_state_notifier.cpp: Copied from
Source/WebKit/efl/ewk/EWebKit.h.

How did you copy this file from a header?