[webkit-reviews] review granted: [Bug 63789] SVGAnimatedType should support SVGAnimatedInteger animation : [Attachment 99444] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 63789: SVGAnimatedType should support SVGAnimatedInteger animation
https://bugs.webkit.org/show_bug.cgi?id=63789

Attachment 99444: Patch
https://bugs.webkit.org/attachment.cgi?id=99444&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=99444&action=review

r=me.

> Source/WebCore/svg/SVGAnimatedInteger.cpp:40
> +    bool ok;
> +    animtedType->integer() = string.toIntStrict(&ok);

Remove the ok.

> Source/WebCore/svg/SVGAnimatedInteger.cpp:84
> +    animatedInt = roundf(result);

static_cast<int>(..)

> LayoutTests/svg/animations/script-tests/svginteger-animation-1.js:39
> +	shouldBe("feConvolveMatrix.targetX.animVal", "0");

would be great if you could add the commented out baseVal statement, so I have
an easier job later:
// shouldBe("feConvolveMatrix.targetX.baseVal", "0")
...

> LayoutTests/svg/animations/script-tests/svginteger-animation-1.js:43
> +	shouldBe("feConvolveMatrix.targetX.animVal", "1");

Ditto.

> LayoutTests/svg/animations/script-tests/svginteger-animation-1.js:47
> +	shouldBe("feConvolveMatrix.targetX.animVal", "2");

Ditto.