[webkit-reviews] review granted: [Bug 53472] Clean up ShadowBlur : [Attachment 80714] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 31 21:18:00 PST 2011


Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 53472: Clean up ShadowBlur
https://bugs.webkit.org/show_bug.cgi?id=53472

Attachment 80714: Patch
https://bugs.webkit.org/attachment.cgi?id=80714&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80714&action=review

> Source/WebCore/platform/graphics/ShadowBlur.cpp:427
> +    shadowContext->setFillColor(Color(.0f, .0f, .0f, 1.f),
ColorSpaceDeviceRGB);

This doesn't need to use the float Color constructor anymore.

> Source/WebCore/platform/graphics/ShadowBlur.cpp:487
> +    shadowContext->setFillColor(Color(.0f, .0f, .0f, 1.f),
ColorSpaceDeviceRGB);

Nor here.


More information about the webkit-reviews mailing list