[webkit-reviews] review denied: [Bug 53468] Handle gpu-backed images in getUnmultipliedImageData() : [Attachment 80708] patch to fix bug

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Mike Reed <reed at google.com>'s
request for review:
Bug 53468: Handle gpu-backed images in getUnmultipliedImageData()
https://bugs.webkit.org/show_bug.cgi?id=53468

Attachment 80708: patch to fix bug
https://bugs.webkit.org/attachment.cgi?id=80708&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80708&action=review

Mostly looks good - R- for the ChangeLog format and whitespace churn.  Can you
also check which tests cover this and put that in the changelog?

> WebCore/ChangeLog:5
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   In Skia platform, ImageBuffer::getUnmultipliedImageData() assumes
that

you're missing a one-line patch description and link to the bugzilla entry
here.  They should go after the Reviewed by line and before the long
description, with a newline separating them from those lines.

> WebCore/ChangeLog:128
> -	   Reapplying this patch again. 
> +	   Reapplying this patch again.

It looks like your editor is stripping trailing newlines.  We don't do that in
WebKit for lines that you aren't otherwise changing as it messes up annotation
data.

> WebCore/platform/graphics/skia/ImageBufferSkia.cpp:5
> - * 
> + *

these changes are unnecessary