[webkit-reviews] review granted: [Bug 53348] Implement media statistics : [Attachment 80530] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 31 17:34:05 PST 2011


Eric Carlson <eric.carlson at apple.com> has granted Steve Lacey
<sjl at chromium.org>'s request for review:
Bug 53348: Implement media statistics
https://bugs.webkit.org/show_bug.cgi?id=53348

Attachment 80530: Patch
https://bugs.webkit.org/attachment.cgi?id=80530&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
Looks good overall, but I am torn about having the compile flag *only* checked
in the IDL. We only need to hide the properties from JavaScript for a port that
doesn't implement this, and I don't think it is necessary to surround all of
the code in every class, I think it could be useful to have it in
HTMLMediaElement so it is clear to anyone looking at the code that it is a
compile time feature.


More information about the webkit-reviews mailing list