[webkit-reviews] review denied: [Bug 53436] [Gtk] atk_text_get_caret_offset fails for list items : [Attachment 80659] Patch proposal + unit test

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 53436: [Gtk] atk_text_get_caret_offset fails for list items
https://bugs.webkit.org/show_bug.cgi?id=53436

Attachment 80659: Patch proposal + unit test
https://bugs.webkit.org/attachment.cgi?id=80659&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80659&action=review

> Source/WebCore/ChangeLog:11
> +	   (webkit_accessible_text_get_caret_offset): Ajust the offset with

Should be "Adjust" here.

> Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:1231
> +	   offset += g_utf8_strlen(markerText.utf8().data(), -1);

Unless I'm mistaken, if you want the offset in bytes, you should use
strlen(markerText.utf8().data()) if you want the offset in characters you can
just use markerText.length().