[webkit-reviews] review granted: [Bug 50036] update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment : [Attachment 77891] Same patch with the addition of ChangeLogs and moved from WebKitTools/ to Tools/

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted sccameron at rim.com's request for
review:
Bug 50036: update run-webkit-httpd to be able to launch Apache2.2 in a MSYS
environment
https://bugs.webkit.org/show_bug.cgi?id=50036

Attachment 77891: Same patch with the addition of ChangeLogs and moved from
WebKitTools/ to Tools/
https://bugs.webkit.org/attachment.cgi?id=77891&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77891&action=review

Looks good to me.

> Tools/Scripts/run-webkit-httpd:5
> +# Copyright (C) Research In Motion Limited 2010. All rights reserved.

Nit: 2010 should be 2011.

> Tools/Scripts/webkitperl/httpd.pm:4
> +# Copyright (C) Research In Motion Limited 2010. All rights reserved.

Ditto.

> Tools/Scripts/webkitperl/httpd.pm:82
> +	   $httpdPath = "/c/program\ files/apache\ software\
foundation/apache2.2/bin/httpd.exe";

It would be nicer if we could write this in such a way that we didn't need to
escape the space characters in the path.