[webkit-reviews] review granted: [Bug 53437] Convert editing/deleting/5168598.html to dumpAsText test : [Attachment 80663] fix patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 31 11:22:50 PST 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Chang Shu <Chang.Shu at nokia.com>'s
request for review:
Bug 53437: Convert editing/deleting/5168598.html to dumpAsText test
https://bugs.webkit.org/show_bug.cgi?id=53437

Attachment 80663: fix patch 2
https://bugs.webkit.org/attachment.cgi?id=80663&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80663&action=review

r+ but you might want to consider hiding input element after printing
PASS/FAIL.

> LayoutTests/editing/deleting/5168598-expected.txt:3
> + PASS

I think the whitespace before PASS will go away if you hid the input element
after the test.


More information about the webkit-reviews mailing list