[webkit-reviews] review granted: [Bug 53232] LightElement changes does not require relayout. : [Attachment 80328] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 31 11:01:17 PST 2011


Dirk Schulze <krit at webkit.org> has granted Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 53232: LightElement changes does not require relayout.
https://bugs.webkit.org/show_bug.cgi?id=53232

Attachment 80328: updated patch
https://bugs.webkit.org/attachment.cgi?id=80328&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80328&action=review

r=me

> Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp:123
> +    ASSERT_NOT_REACHED();

Is this assertion correct here? Why can't/shouldn't we pass a wrong attribute
here?


More information about the webkit-reviews mailing list