[webkit-reviews] review granted: [Bug 53432] Make LayerTreeHost an abstract base class and make LayerTreeHostMac inherit from it : [Attachment 80651] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 31 10:02:43 PST 2011
Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 53432: Make LayerTreeHost an abstract base class and make LayerTreeHostMac
inherit from it
https://bugs.webkit.org/show_bug.cgi?id=53432
Attachment 80651: Patch
https://bugs.webkit.org/attachment.cgi?id=80651&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80651&action=review
Maybe WebPorcess/WebPage/ca/LayerTreeHostCA.mm would be more appropriate?
> Source/WebKit2/WebProcess/WebPage/LayerTreeHost.cpp:47
> + return adoptPtr(static_cast<LayerTreeHost*>(new
LayerTreeHostMac(webPage, graphicsLayer)));
Is the cast really needed here?
More information about the webkit-reviews
mailing list