[webkit-reviews] review granted: [Bug 53389] [Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful : [Attachment 80646] Patch proposal + unit tests

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 53389: [Gtk] atk_text_set_caret_offset returns True even when it is
unsuccessful
https://bugs.webkit.org/show_bug.cgi?id=53389

Attachment 80646: Patch proposal + unit tests
https://bugs.webkit.org/attachment.cgi?id=80646&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80646&action=review

> Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:1714
> +    RenderObject* renderer =
toAccessibilityRenderObject(coreObject)->renderer();
> +    if (renderer && renderer->isListItem()) {
> +	   String markerText =
toRenderListItem(renderer)->markerTextWithSuffix();
> +	   int markerLength = g_utf8_strlen(markerText.utf8().data(), -1);
> +	   if (offset < markerLength)
> +	       return FALSE;
> +
> +	   // We need to adjust the offset for list items.
> +	   offset -= markerLength;
> +    }

Please mention this change in the ChangeLog as well.