[webkit-reviews] review granted: [Bug 52990] [EFL] Add an API to get proxy address : [Attachment 80012] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 31 06:32:54 PST 2011


Antonio Gomes <tonikitoo at webkit.org> has granted  review:
Bug 52990: [EFL] Add an API to get proxy address
https://bugs.webkit.org/show_bug.cgi?id=52990

Attachment 80012: Patch
https://bugs.webkit.org/attachment.cgi?id=80012&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80012&action=review

Next time you can just reupload it with "Reviewed by Antonio Gomes", and set
cq+ yourself ;)

> Source/WebKit/efl/ChangeLog:9
> +	   which is set up by ewk_settings_proxy_uri_set().

I would also mention that it only implements the API for libsoup network
backend.

> Source/WebKit/efl/ewk/ewk_settings.cpp:294
> + * Gets the proxy URI from network backend.

from THE network backend.


More information about the webkit-reviews mailing list