[webkit-reviews] review denied: [Bug 53188] requestAnimationFrame callbacks should not fire within a modal dialog : [Attachment 80622] without ActiveDOMObject

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied James Robinson
<jamesr at chromium.org>'s request for review:
Bug 53188: requestAnimationFrame callbacks should not fire within a modal
dialog
https://bugs.webkit.org/show_bug.cgi?id=53188

Attachment 80622: without ActiveDOMObject
https://bugs.webkit.org/attachment.cgi?id=80622&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80622&action=review

It may be unfair to pick on a single patch to question run to completion, and
maybe my comments sound out of context because of that. But I do think that
these issues need to be discussed in the WebKit community, and this time is as
good as any. There doesn't seem to be any rush - I can see no indication that
Mozilla will be changing this behavior before Firefox 5.

> Source/WebCore/dom/Document.cpp:4741
> +void Document::suspendActiveDOMObjects(ActiveDOMObject::ReasonForSuspension
reason)
> +{
> +    ScriptExecutionContext::suspendActiveDOMObjects(reason);
> +#if ENABLE(REQUEST_ANIMATION_FRAME)
> +    if (m_requestAnimationFrameController)
> +	   m_requestAnimationFrameController->suspend();
> +#endif
> +}

I think it should be obvious that this is a no-go. A function called
suspendActiveDOMObjects() cannot be affecting things that aren't
ActiveDOMObjects.