[webkit-reviews] review denied: [Bug 53188] requestAnimationFrame callbacks should not fire within a modal dialog : [Attachment 80618] adds a test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 30 22:17:37 PST 2011


Alexey Proskuryakov <ap at webkit.org> has denied James Robinson
<jamesr at chromium.org>'s request for review:
Bug 53188: requestAnimationFrame callbacks should not fire within a modal
dialog
https://bugs.webkit.org/show_bug.cgi?id=53188

Attachment 80618: adds a test
https://bugs.webkit.org/attachment.cgi?id=80618&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
ActiveDOMObject shouldn't be used with objects that don't have a JS wrapper.

Darin mentioned that this fix breaks "nice animations". If so, just do this. We
can revisit this after Firefox 5 comes out, and if it really has this fix.


More information about the webkit-reviews mailing list