[webkit-reviews] review denied: [Bug 52846] InsertUnorderedList breaks up paragraphs when they contain non-editable elements. : [Attachment 80557] Proposed patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Raffaele <alberthilbert at gmail.com>'s
request for review:
Bug 52846: InsertUnorderedList breaks up paragraphs when they contain
non-editable elements.
https://bugs.webkit.org/show_bug.cgi?id=52846

Attachment 80557: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=80557&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80557&action=review

> Source/WebCore/editing/InsertListCommand.cpp:331
> -    VisiblePosition start = startOfParagraph(originalStart);
> -    VisiblePosition end = endOfParagraph(start);
> +    VisiblePosition start = startOfParagraph(originalStart,
CanCrossEditingBoundary);
> +    VisiblePosition end = endOfParagraph(start, CanCrossEditingBoundary);

How do we ensure that the entire paragraph is editable if we allow start/end to
cross editing boundary?  For example, if we had <div
contenteditable="false">hello <span contenteditable="true">world</span></div>,
and the caret is inside the span, we shouldn't be listifying "hello world".

Because of deep equivalent positions, I don't think we're ready to fix this
kind of bugs properly yet.  Also, please don't just fix InsertUnorderedList. 
At least InsertOrderedList must also be fixed.	And I'm sure the same bug
exists for IndentOutdentCommand and FormatBlockCommand.  If you're interested
in working on InsertListCommand, please fix crash/hang bugs we have as they
have a higher priority.