[webkit-reviews] review granted: [Bug 53202] Async event handlers should not fire within a modal dialog : [Attachment 80504] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 53202: Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Attachment 80504: Patch
https://bugs.webkit.org/attachment.cgi?id=80504&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80504&action=review

Looks good to me.  For posterity this behavior is specified by
http://www.whatwg.org/specs/web-apps/current-work/multipage/timers.html#dom-ale
rt (for alert(), confirm(), print()) and
http://www.whatwg.org/specs/web-apps/current-work/multipage/timers.html#dom-sho
wmodaldialog step 5 for showModalDialog().

> Source/WebCore/dom/EventQueue.h:59
> +    virtual ~EventQueue();

why virtual? I can't find any subclasses of EventQueue in the codebase
currently