[webkit-reviews] review denied: [Bug 53398] Use Document::encoding() instead of DocumentWriter::encoding() : [Attachment 80594] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 53398: Use Document::encoding() instead of DocumentWriter::encoding()
https://bugs.webkit.org/show_bug.cgi?id=53398

Attachment 80594: Patch
https://bugs.webkit.org/attachment.cgi?id=80594&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80594&action=review

R- for using a virtual method when a non-virtual one does the same job.  Also,
one question:

> Source/WebCore/ChangeLog:6
> +	   Use Document::encoding() instead of DocumentWriter::encoding()
> +	   https://bugs.webkit.org/show_bug.cgi?id=53398

Do you mean Document::charset?	Document.h says: "Use Document::encoding() to
avoid virtual dispatch" but you're not doing that...  Are these two always the
same?