[webkit-reviews] review granted: [Bug 53391] Switched heap to use the Bitmap class and removed CollectorBitmap : [Attachment 80586] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 29 21:48:34 PST 2011


Maciej Stachowiak <mjs at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 53391: Switched heap to use the Bitmap class and removed CollectorBitmap
https://bugs.webkit.org/show_bug.cgi?id=53391

Attachment 80586: Patch
https://bugs.webkit.org/attachment.cgi?id=80586&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80586&action=review

r=me; see tiny comment though.

> Source/JavaScriptCore/wtf/Bitmap.h:79
> +inline bool Bitmap<size>::getset(size_t n)

I think testAndSet would be a more conventional name for this operation.


More information about the webkit-reviews mailing list