[webkit-reviews] review granted: [Bug 53383] Add WKPageCopyPendingURL API; returns the last URL requested for load via API before reaching provisional state : [Attachment 80585] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 53383: Add WKPageCopyPendingURL API; returns the last URL requested for
load via API before reaching provisional state
https://bugs.webkit.org/show_bug.cgi?id=53383

Attachment 80585: Patch
https://bugs.webkit.org/attachment.cgi?id=80585&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80585&action=review

The distinction between the dual concepts of "pending" and "provisional" is
very subtle here. You should consider giving the two more distinctive names in
the future.

I want to make a suggestion, but I'm not sure exactly why a requested URL
doesn't immediately enter the provisional state.

r=me

> Source/WebKit2/ChangeLog:6
> +	   Add WKPageCopyPendingURL API; returns the last URL requested for
load via API before reaching provisional state
> +	   https://bugs.webkit.org/show_bug.cgi?id=53383

I had a hard time parsing this sentence. I think you mean, "returns the last
API-requested URL even if that URL hasn't reached the provisional state yet."