[webkit-reviews] review canceled: [Bug 50747] [GTK] drop soup cache stuff, use versions from libsoup : [Attachment 80568] updated patch (for source tree moves and some other stuff)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 29 14:45:26 PST 2011


Dan Winship <danw at gnome.org> has canceled Dan Winship <danw at gnome.org>'s
request for review:
Bug 50747: [GTK] drop soup cache stuff, use versions from libsoup
https://bugs.webkit.org/show_bug.cgi?id=50747

Attachment 80568: updated patch (for source tree moves and some other stuff)
https://bugs.webkit.org/attachment.cgi?id=80568&action=review

------- Additional Comments from Dan Winship <danw at gnome.org>
The NULL-vs-0 warning from check-webkit-style is wrong. Apparently we could
suppress it by squishing the entire g_object_set() call onto a single line, but
I didn't do that because (a) it would be ugly, and (b) that code was already in
ResourceHandleSoup.cpp anyway, I just moved it within the file.


More information about the webkit-reviews mailing list