[webkit-reviews] review denied: [Bug 53296]=?UTF-8?Q?=20Implicit=20form=20submission=20shouldn=E2=80=99t=20work=20when=20the=20default=20button=20is=20disabled=20?=: [Attachment 80564] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 29 09:06:50 PST 2011


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Mathias Bynens
<mathias at qiwi.be>'s request for review:
Bug 53296: Implicit form submission shouldn’t work when the default button is
disabled
https://bugs.webkit.org/show_bug.cgi?id=53296

Attachment 80564: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=80564&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Looks reasonable. All that it's missing to be a good patch is:
a) Layout test -- use your reduction to create one. Read up layout tests on
webkit.org/blog.
b) ChangeLog. -- use Tools/Scripts/webkit-patch to upload the patch. It will
ensure your patch has the proper log.


More information about the webkit-reviews mailing list