[webkit-reviews] review granted: [Bug 51809] [Chromium] Autofill should work with HTML5 form elements : [Attachment 80538] Change comment and const version.

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 51809: [Chromium] Autofill should work with HTML5 form elements
https://bugs.webkit.org/show_bug.cgi?id=51809

Attachment 80538: Change comment and const version.
https://bugs.webkit.org/attachment.cgi?id=80538&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80538&action=review

R=me, but CQ- because of the indentation nit.

> Source/WebKit/chromium/public/WebInputElement.h:96
> +	     return toWebInputElement(const_cast<WebElement*>(element));

nit: indentation should be 4 spaces

> Source/WebKit/chromium/src/WebInputElement.cpp:182
> +    ASSERT(inputElement->isHTMLElement());

nit: I'm not so sure if this assertion is appropriate, but since we don't
make a big distinction between HTML and non-HTML documents in the WebKit
API, I guess it is OK here until we find that we trip over it.