[webkit-reviews] review granted: [Bug 42682] WebKitTestRunner needs layoutTestController.setPOSIXLocale : [Attachment 80529] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 42682: WebKitTestRunner needs layoutTestController.setPOSIXLocale
https://bugs.webkit.org/show_bug.cgi?id=42682

Attachment 80529: Patch
https://bugs.webkit.org/attachment.cgi?id=80529&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80529&action=review

> Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:378
> +    JSStringGetUTF8CString(locale, localeBuf, sizeof(localeBuf));
> +    setlocale(LC_ALL, localeBuf);

Would be nicer to safely do nothing if JSStringGetUTF8CString fails.